Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-42941: Using default axis labels for astrom and photom focalPlanePlots #209

Merged
merged 2 commits into from Feb 20, 2024
Merged

DM-42941: Using default axis labels for astrom and photom focalPlanePlots #209

merged 2 commits into from Feb 20, 2024

Conversation

jrmullaney
Copy link
Contributor

Default axis labels include units (mm).

@jrmullaney jrmullaney marked this pull request as ready for review February 19, 2024 16:16
cmsaunders
cmsaunders approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@cmsaunders cmsaunders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. You probably want to change these lines too:

analysis_tools/python/lsst/analysis/tools/atools/calibration.py

Line 54 in 14baeae

self.produce.plot.xAxisLabel = "x (focal plane)"

@jrmullaney jrmullaney merged commit c8476c5 into main Feb 20, 2024
8 checks passed
@jrmullaney jrmullaney deleted the tickets/DM-42941 branch February 20, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmsaunders cmsaunders cmsaunders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrmullaney @cmsaunders