Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/DM-42672: Create FocalPlaneGeometryPlots for biasMean, biasNoise, biasCRNoise, biasShiftCount #213

Merged
merged 9 commits into from Feb 28, 2024

Conversation

jrmullaney
Copy link
Contributor

@jrmullaney jrmullaney commented Feb 26, 2024

I've included quantityKey and unit as input parameters to calibration.py. The reason for the former is to simplify the pipeline.yaml file, while the latter allows for the unit to be included in the dynamically-poduced zAxisLabel.

Please see the JIRA ticket for plot examples.

Jenkins currently running.

Since the calibration verification tables all have
similar structures, the same task and tools can
be used to analyse many different tables and columns.
This commit generalises atools/calibration.py and
tasks/calibrationAnalysis.py for this purpose.
To automatically generate the z-axis label.
@jrmullaney jrmullaney requested a review from czwa February 26, 2024 23:08
Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jrmullaney jrmullaney merged commit f0a709b into main Feb 28, 2024
8 checks passed
@jrmullaney jrmullaney deleted the tickets/DM-42672 branch February 28, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants