DM-41108: Temporarily remove broken AP metrics #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-41108
branch
from
7597dc5
to
12a632c
Compare
kfindeisen
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Neither apDetectorVisitQualityCore nor "Tier 1 AP plots and metrics to assess CcdVisit quality" really makes it clear how these metrics will be used.
Is the plan that this file can only contain metrics that wouldn't be disruptive to real-time processing? If so, a warning about the restriction should be present in the name, description, or both. (I'm assuming, of course, that there'd be a bigger and slower set of metrics somewhere for batch or daytime processing...)
isullivan
force-pushed
the
tickets/DM-41108
branch
4 times, most recently
from
d8a7b1e
to
f38f02e
Compare
kfindeisen
approved these changes
Mar 15, 2024
| @@ -1,6 +1,9 @@ | |||
| description: | | |||
| AP plots and metrics to assess CcdVisit quality in Prompt Processing | |||
| Additional AP metrics may be written in apDetectorVisitQualityExtended | |||
| parameters: | |||
| coaddName: goodSeeing | |||
| fakesType: '' | |||
There was a problem hiding this comment.
Does this need a comment saying that the parameter names are shared with ApPipe (I assume that's the intent)?
Avoids bugs when units are set to counts ('ct')
isullivan
force-pushed
the
tickets/DM-41108
branch
from
f38f02e
to
21706a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be added back in DM-43201