DM-42088 Add a check for invalid characters in measurement names #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
force-pushed
the
tickets/DM-42088
branch
2 times, most recently
from
880c9a0
to
1fcec49
Compare
leeskelvin
approved these changes
Mar 14, 2024
Comment on lines
190
to
191
| # Yes this should be a log here, as pex config give us no other | ||
| # useful way to get info into the exception. |
There was a problem hiding this comment.
Rather than a raise?
Typo: give to gives.
There was a problem hiding this comment.
Yeah, because I want the pex_execution framework to raise a FieldValidationError which it will do with the check function. That exception is the one that various tools will be looking for, but there also not an easy way to raise it yourself (you need access to various objects) I thought about hacking various complicated things to make it do what you might expect, but I figured it was not worth the time. This will log an exact message, and the standard exception WILL have a message containing the actual text of the invalid value.
natelust
force-pushed
the
tickets/DM-42088
branch
from
1fcec49
to
0065574
Compare
Avro does not like minus characters in measurement names. Change to avoid problem.
Add a check when specifying measurement names that they do not contain characters that will be a problem for avro schemas.
natelust
force-pushed
the
tickets/DM-42088
branch
from
0065574
to
d8a7716
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.