DM-43404: Add diffim QA plots #231
Conversation
isullivan
force-pushed
the
tickets/DM-43404
branch
4 times, most recently
from
1a29b89
to
9d27563
Compare
| @@ -6,6 +6,7 @@ | |||
| from .cpVerifyQuantityProfile import * | |||
| from .deblenderMetric import * | |||
| from .deltaSkyCorr import * | |||
| from .diaMetricsPlots import * | |||
There was a problem hiding this comment.
The name here is confusing, because "metrics" here doesn't mean analysis_tools metrics, but the metrics stored in source catalogs. Is there a way we can make this more clear?
There was a problem hiding this comment.
I renamed the module to diaSpatialMetricsPlots. Does that help? I could also go with diaSpatiallySampledMetricsPlots
|
|
||
|
|
||
| class DiffimMetricsInterpolatePlot(AnalysisTool): | ||
| """Interpolate metric values evaluated at locations in a supplied catalog |
There was a problem hiding this comment.
Again, I'm worried about overloading the word "metric" here to mean very different software representations. (You could make an analysis_tools metric from these "metrics", for instance.)
There was a problem hiding this comment.
I changed the wording.
isullivan
force-pushed
the
tickets/DM-43404
branch
3 times, most recently
from
7097f63
to
b54de91
Compare
| pass | ||
|
|
||
|
|
||
| class DiffimDetectorVisitPlotsAnalysisTask(AnalysisPipelineTask): |
There was a problem hiding this comment.
Apologies, I think this probably needs a rename as well, since it only takes the spatially sampled metrics as input (rather than something more general to diffim.) DiffimDetectorVisitSpatiallySampledPlots?
There was a problem hiding this comment.
I'll go with DiffimDetectorVisitSpatiallySampledMetricsTask, to match the dataset name.
Note that this is a hack, since plotInfo does not support single band and single detector plots
isullivan
force-pushed
the
tickets/DM-43404
branch
3 times, most recently
from
5f5abe6
to
65f4d1e
Compare
isullivan
force-pushed
the
tickets/DM-43404
branch
from
65f4d1e
to
24c0fdb
Compare
No description provided.