Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-43681: Add calexpMetrics atool to AP metrics afterburner #233

Merged
merged 2 commits into from Apr 11, 2024
Merged

DM-43681: Add calexpMetrics atool to AP metrics afterburner #233

merged 2 commits into from Apr 11, 2024

Conversation

ebellm
Copy link
Contributor

@ebellm ebellm commented Apr 8, 2024

No description provided.

@ebellm ebellm requested a review from isullivan April 11, 2024 21:05
isullivan
isullivan approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please rename the metrics to avoid the old calexp name, and add the fakesType to the connections.

pipelines/apDetectorVisitQualityCore.yaml Show resolved Hide resolved
pipelines/apDetectorVisitQualityCore.yaml Outdated Show resolved Hide resolved
@ebellm ebellm merged commit 38f4de6 into main Apr 11, 2024
8 checks passed
@ebellm ebellm deleted the tickets/DM-43681 branch April 11, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isullivan isullivan isullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ebellm @isullivan