DM-42927: Update cp_verify connections/classes/outputs for analysis_tools #237
Conversation
czwa
force-pushed
the
tickets/DM-42927
branch
2 times, most recently
from
569a7d9
to
47f83fa
Compare
| # atools.defectsBadColumns.produce.plot.zAxisLabel: "Number of Hot Pixels" | ||
| # atools.defectsBadColumns.quantityKey: DEFECTS_DEFECTS_DIST_N_BAD_COLUMNS | ||
| # atools.defectsBadColumns.unit: "---" | ||
| python: | |
There was a problem hiding this comment.
Should all these commented out bits be here?
There was a problem hiding this comment.
I've left commented blocks that have associated JIRA tickets. I think in most of these cases, the commented code will work once those tickets merge (and hopefully un-comment these blocks).
| ylabel = Field[str]( | ||
| doc="String argument passed into fig.supylabel() defining the figure y label.", | ||
| optional=True, | ||
| ) |
There was a problem hiding this comment.
Can we make these xAxisLabel and yAxisLabel to bring them inline with other plots?
| if xList is not None: | ||
| namedKey = self.panels[index].plotElement.xKey | ||
| newData[namedKey] = data[xList[i]] | ||
| if key in xList: |
There was a problem hiding this comment.
I know that you didn't write most of this section but some comments in here would be really useful.
There was a problem hiding this comment.
Documented as best I could since I'll likely need to work on this again. There are multiple levels of indirection that make this tool difficult to use.
| 2: "PTC_COV_01", | ||
| 3: "PTC_COV_02", | ||
| 4: "PTC_COV_11", | ||
| 5: None, |
There was a problem hiding this comment.
Grid plot needs to be able to generate an N*M grid of panels, but I only need 5, and 5 is unfortunately prime. By setting this to None, no columns will match, and the sixth panel will be empty.
| if xList is not None: | ||
| namedKey = self.panels[index].plotElement.xKey | ||
| newData[namedKey] = data[xList[i]] | ||
| if key in xList: |
There was a problem hiding this comment.
Documented as best I could since I'll likely need to work on this again. There are multiple levels of indirection that make this tool difficult to use.
| 2: "PTC_COV_01", | ||
| 3: "PTC_COV_02", | ||
| 4: "PTC_COV_11", | ||
| 5: None, |
There was a problem hiding this comment.
Grid plot needs to be able to generate an N*M grid of panels, but I only need 5, and 5 is unfortunately prime. By setting this to None, no columns will match, and the sixth panel will be empty.
czwa
force-pushed
the
tickets/DM-42927
branch
4 times, most recently
from
1f88af9
to
d3f9077
Compare
This also splits these into "Core" and "Extended" categories.
Add xy labels Remove unnecessary fig.show().
Add additional repacking method. Add additional plot arrangements.
This updates the handling of calibration products. I've renamed some classes and files to be more informative. This also updates the
GridPlotcode to fix the column-vs-column plotting.