DM-35818: Fix and refactor various actions

[taranu]

No description provided.

[fred3m]

Just a few small comments and suggestions.

[fred3m]

Your mixed use of snake and camel case variables in this class is confusing. Please pick an animal and stick with it :). In the case of this package, it looks like camel case is the default.

[taranu]

Well, I guess I don't know how to politely tell everyone else that they're wrong because the dev guide says snake_case should be the default in primarily new code, which this package definitely is (and analysis_drp was too). None of it should have been written in camelCase in the first place.

[fred3m]

I prefer countName (and the same with maskName, medianName, etc), but if you feel strongly its ok to leave as nameCount etc.

[taranu]

I decided to stick with snake_case (someone can yell at me later about it). But this one I always find tricky. Our classes will always be CamelCase, and it seems reasonable to say camelCase = CamelCase() # variable. But when you have N different things of the same logical type, I find it more convenient to have them prefixed and sorted by that type. Unfortunately, I think both name_count and count_name are potentially ambiguous depending on the convention (is it the name of the count or the count of a name?), so... 🤷🏼

[fred3m]

I wonder if maximum and minimum should allow for None values. For example, if maximum is None then this would act as a threshold selector, only setting a lower bound; and if minimum is None then this would act as a ceiling selector.

[taranu]

I had a reason for not putting in defaults, but I couldn't remember it, so I added them.