DM-36220: Allow plotInfo to be None #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-36220
branch
from
db141a1
to
f8f3e45
Compare
sr525
reviewed
Sep 21, 2022
| @@ -262,7 +262,7 @@ def addPlotInfo(fig, plotInfo): | |||
| for band in plotInfo["bands"]: | |||
| bandText += band + ", " | |||
| bandsText = f", Bands: {bandText[:-2]}" | |||
| SNText = f", S/N: {plotInfo['SN']}" | |||
| SNText = f", S/N: {plotInfo['SN']}" if "SN" in plotInfo.keys() else "" | |||
There was a problem hiding this comment.
I just put in a fix for this on another ticket. I added a "-" rather than a "".
There was a problem hiding this comment.
Great! I will remove this change from this PR, then.
isullivan
force-pushed
the
tickets/DM-36220
branch
from
f8f3e45
to
0b04c87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.