DM-36234: Create AP Number of Associated Solar System Objects metric in analysis_tools #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebellm
force-pushed
the
tickets/DM-36234
branch
from
ab95e79
to
f671817
Compare
sr525
reviewed
Sep 14, 2022
| class DiaSourceTableCcdVisitAnalysisConnections( | ||
| AnalysisBaseConnections, | ||
| dimensions=("visit", "band"), | ||
| defaultTemplates={"coaddName": "deep", "fakesType": "fakes_"}, |
There was a problem hiding this comment.
We're trying to move to SI rather than fakes, siType and si_.
There was a problem hiding this comment.
We use fakesType throughout AP, including in the upstream data products, so I propose to maintain it here.
There was a problem hiding this comment.
Benching this discussion for now to be readdressed later.
sr525
reviewed
Sep 14, 2022
sr525
reviewed
Sep 14, 2022
|
fakees -> si discussion aside this looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.