DM-29421: Add AP plots in analysis_ap using analysis_tools #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
force-pushed
the
tickets/DM-29421
branch
2 times, most recently
from
a96d112
to
bb66765
Compare
mrawls
force-pushed
the
tickets/DM-29421
branch
2 times, most recently
from
90d626b
to
ef0dd6e
Compare
|
As part of the review, I need some assistance getting the modified pipeline to run before this is ready to merge. At the moment, when I run The result is as follows |
mrawls
force-pushed
the
tickets/DM-29421
branch
4 times, most recently
from
ee2cc67
to
1234289
Compare
|
This should be all set now and ready for your actual review! |
natelust
approved these changes
Oct 26, 2022
| @@ -20,13 +20,16 @@ | |||
| # along with this program. If not, see <https://www.gnu.org/licenses/>. | |||
| from __future__ import annotations | |||
|
|
|||
| __all__ = "PlotConfig" | |||
There was a problem hiding this comment.
This needs to be in () like __all__ = ("PlotConfig", ) otherwise some things will iterate over the string
| def setDefaults(self): | ||
| super().setDefaults() | ||
|
|
||
| self.process.buildActions.ras = LoadVector() |
There was a problem hiding this comment.
I don't think you need process at all here you can just do:
self.prep.vectorKeys = ['ra', 'decl']
...
self.produce.panels['panel_main'].ra = 'ra'
self.produce.panels['panel_main'].dec = 'decl'
Again, this is just an alternative way to write this that may be more convenient, or may not be depending on how you think about things
|
|
||
|
|
||
| class PanelConfig(Config): | ||
| """Configuration options for plot panels.""" |
There was a problem hiding this comment.
Consider a bit more of a doc string, its not really panels for ANY plot
|
|
||
| class DiaSkyPlot(PlotAction): | ||
| """Generic pseudo base class for plotting DiaSources | ||
| (or DiaObjects) on the sky. |
There was a problem hiding this comment.
This doc string seems awkward for some reason, is the line break in the right place?
mrawls
force-pushed
the
tickets/DM-29421
branch
from
1234289
to
7b3d4f3
Compare
Also add a PanelConfig class to plotUtils that can be used to turn various matplotlib knobs pertaining to subplot layout.
mrawls
force-pushed
the
tickets/DM-29421
branch
from
7b3d4f3
to
4503563
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new plotting capability for DiaSources on the sky. The simple version of this plot is here in
analysis_tools, and a specialized version for a specific AP QA data set is inanalysis_ap.