New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tickets/dm-36246 #33
Tickets/dm-36246 #33
Conversation
8e6fe05
to
07123e9
Compare
First thing I note is that the git history on this is going to need fixed up before merge. Please squash the fixups into the code. Additionally, I suspect you hit the Github button to bring your branch up to date with main. However, we rebase our branches against main instead, so you may need to drop that commit and rebase. If you need help doing any of that let me know, and we can set up a time to work through it. |
I think if you rebase, by default merge commits are dropped. |
python/lsst/analysis/tools/analysisMetrics/apDiaSourceMetrics.py
Outdated
Show resolved
Hide resolved
97e42fd
to
51044bc
Compare
I am not sure how to squash all of my commits at this stage, but if its like Tim said and a rebase onto main would fix it I can do it that way. |
|
"psFluxMeanMetric": "flx", | ||
"apFluxMeanMetric": "flx", | ||
"totFluxMeanMetric": "flx", | ||
"psFluxMedianMetric": "flx", | ||
"apFluxMedianMetric": "flx", | ||
"totFluxMedianMetric": "flx", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these need to be "flx"
or could you write out "flux"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it turns out, flux is not a valid unit and would have to be added as a custom unit to work. flx, or STflux are valid units. I did test it out with flux and it broke the code.
b3bf8f4
to
ed9abce
Compare
ed9abce
to
c2524ce
Compare
Added simple metrics for the median and mean of the psf, aperture, and total flux. Added a plot for comparing the ratio of the psf to aperture flux.