Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/DM-36263: Creating Seeing metric and Assoc/Unassoc Sources metric and plots #43

Merged
merged 2 commits into from Dec 8, 2022

Conversation

bsmartradio
Copy link
Contributor

Create Analysis_Tools metric and plots for unassociatedDiasources and min/max/median seeing. Added a new metric, unique, to count unique items in a vector. Create a base class for sources, which creates three vectors containing all sources, associated, and unassociated sources. Added a pipeline which creates the metrics and plots for assoc/unassociated sources.

@bsmartradio bsmartradio force-pushed the tickets/DM-36263 branch 3 times, most recently from 4315a43 to ba0aebe Compare November 21, 2022 21:29
Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a number of questions about naming and documentation. Also, make sure to add __all__ to each new file that will have classes imported in __init__.py.

@bsmartradio bsmartradio force-pushed the tickets/DM-36263 branch 2 times, most recently from 6a67e1b to 50c73d2 Compare November 28, 2022 18:31
Adding source base class and seeing metric for use in creating source metrics. Seeing metric uses the ccdVisit table to look at the median, max, and min seeing.


Add git ignore
@bsmartradio bsmartradio force-pushed the tickets/DM-36263 branch 2 times, most recently from 2fcf5fc to a17f3de Compare December 8, 2022 19:56
Adding metrics on associated and unassociated sources, as well as pipeline to create a bar graph comparing associated and unassociated sources. 
Rename demoMetric


Lint fix


Typo Fix


Formatting Fix


Add __all__ and updated docstrings


Formatting fixes


Small fix


Removed repeated Unique Action


Updated docstring


Updated formatting
@bsmartradio bsmartradio merged commit 9d86d89 into main Dec 8, 2022
@bsmartradio bsmartradio deleted the tickets/DM-36263 branch December 8, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants