Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-34840: Remove the toDict method override #53

Merged
merged 2 commits into from
Jan 9, 2023
Merged

DM-34840: Remove the toDict method override #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eda817c
Remove the toDict override for BinnedCorr2Config
arunkannawadi Jan 3, 2023
78ff56c
Update COPYRIGHT
arunkannawadi Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions COPYRIGHT
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
Copyright 2022-2023 The Trustees of Princeton University
Copyright 2022-2023 University of Washington
Copyright 2022 Association of Universities for Research in Astronomy, Inc. (AURA)
Copyright 2022 The Board of Trustees of the Leland Stanford Junior University, through SLAC National Accelerator Laboratory
10 changes: 1 addition & 9 deletions python/lsst/analysis/tools/actions/vector/calcRhoStatistics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ class BinnedCorr2Config(Config):
A separate config class is used instead
of constructing a `~lsst.pex.config.DictField` so that mixed types can be
supported and the config can be validated at the beginning of the
execution. The ``toDict`` provides a minimal dictionary that overrides only
the default values and excludes the key-value pairs when the item is None.
execution.

Notes
-----
Expand Down Expand Up @@ -232,13 +231,6 @@ def validate(self):
if self.min_sep > self.max_sep:
raise FieldValidationError(self.__class__.min_sep, self, "min_sep must be <= max_sep")

def toDict(self):
# Docs inherited from base class
# We are excluding items that are None due to treecorr limitations.
# TODO: DM-38480. This override can be removed after treecorr v4.3
# makes its way onto rubin-env.
return {k: v for k, v in super().toDict().items() if v is not None}


class CalcRhoStatistics(KeyedDataAction):
r"""Calculate rho statistics
Expand Down