DM-37635: Cleanup analysis_tools to fix pipelines docs build failure #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktlim
approved these changes
Jan 24, 2023
python/lsst/analysis/tools/tasks/associatedSourcesTractAnalysis.py
Outdated
Show resolved
Hide resolved
| @@ -31,6 +31,8 @@ | |||
| connection classes and should specify a unique name | |||
| """ | |||
|
|
|||
| __all__ = ("AnalysisBaseConfig", "AnalysisPipelineTask") | |||
There was a problem hiding this comment.
Is AnalysisBaseConnections needed as well? See diaObjectTableAssocAnalysis.py and others.
There was a problem hiding this comment.
I've generally assumed that Connections classes should not be part of the public API, since you never need to import them as far as I'm aware. Configs do get imported and modified. I've asked on #dm-science-pipelines about this.
I converted lists to tuples, moved them to the top of the files (just under any __future__ statements), and made sure they had Task/Config in those files.
We have some type definitions that we want in the docs, too.
parejkoj
force-pushed
the
tickets/DM-37635
branch
from
cb5f60d
to
c093619
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.