DM-36446: Add size vs magnitude plots to analysis_tools #65
Conversation
taranu
force-pushed
the
tickets/DM-36446
branch
3 times, most recently
from
449e5e0
to
a445d57
Compare
taranu
force-pushed
the
tickets/DM-36446
branch
2 times, most recently
from
206a9e1
to
1abfedd
Compare
taranu
force-pushed
the
tickets/DM-36446
branch
3 times, most recently
from
7c5a55c
to
77aa16c
Compare
taranu
force-pushed
the
tickets/DM-36446
branch
7 times, most recently
from
25a3534
to
c52f5aa
Compare
taranu
force-pushed
the
tickets/DM-36446
branch
2 times, most recently
from
ff7ef83
to
fcd5022
Compare
taranu
force-pushed
the
tickets/DM-36446
branch
2 times, most recently
from
2d28fd9
to
5cc64b8
Compare
| "ExponentiateFromBaseVector", | ||
| "ExponentiateToPowerVector", |
There was a problem hiding this comment.
"Exponentiate"? I realize this is the correct usage of the word here, but it feels overly verbose. Can we agree to use ExpFromBaseVector and ExpToPowerVector and pretend that "Exp" stands for "Exponentiate"?
There was a problem hiding this comment.
"exp" implies e^x, which is not what this is. The other alternative I considered was RaiseToPower. I didn't like that partly because raise is a Python keyword, and I'm not sure if RaiseFromBase makes sense.
There was a problem hiding this comment.
Exponentiate is a confusing term, I think (at least, it is to me). I slightly prefer RaiseToPower and RaiseFromBase, but I accept your point that Raise is a protected word in other contexts. Although perhaps that's not an issue here?
|
|
||
| compute_chi = Field[bool]( | ||
| default=False, | ||
| doc="Whether to compute scaled flux residuals (chi)" " instead of magnitude differences", |
There was a problem hiding this comment.
Badly formatted double "".
|
|
||
|
|
||
| class FluxConfig(Config): | ||
| """Configuration for a flux vector to be loaded and potentially plotted""" |
| setattr(target, name, action(*args, **kwargs)) | ||
|
|
||
| def _set_flux_default(self, attr): | ||
| """Set own config attr to appropriate string flux name""" |
| shape_slot=SizeConfig(key_size="shape_{suffix}", name_size="Shape slot radius"), | ||
| ) | ||
| size_type = ChoiceField[str]( | ||
| doc="The type of size to calculate", |
There was a problem hiding this comment.
Here (and other config fields), missing period. However, if a few slip through, I'm not overly concerned.
| ) | ||
|
|
||
| def _check_attr(self, name_size: str): | ||
| """Check if a buildAction has already been set""" |
taranu
force-pushed
the
tickets/DM-36446
branch
3 times, most recently
from
665d1c9
to
2d7d3c7
Compare
This also includes a significant refactoring of matched difference plots/metrics so that they share some base classes.