DM-38372: Switch to numpy random generator for test_catalogMatch and add seed #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
approved these changes
Mar 20, 2023
tests/test_catalogMatch.py
Outdated
| @@ -32,6 +32,8 @@ | |||
| from lsst.daf.butler import DatasetRef, DatasetType, DimensionUniverse, StorageClass | |||
| from lsst.meas.algorithms import ReferenceObjectLoader | |||
|
|
|||
| rng = np.random.default_rng(12345) | |||
There was a problem hiding this comment.
Since you are no longer relying on modifying global numpy random behavior and are using an instance of a random generator, can you move this to be an instance variable of the class you use it in?
|
Thanks! Yes, I'll squash. I should have said that I was planning to squash once the review was done. |
cmsaunders
force-pushed
the
tickets/DM-38372
branch
from
59b6dd6
to
d7f1dc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.