DM-37918: Structural changes to the package #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
force-pushed
the
tickets/DM-37918
branch
from
c8dcb16
to
f39aeea
Compare
bechtol
approved these changes
Apr 25, 2023
natelust
force-pushed
the
tickets/DM-37918
branch
2 times, most recently
from
30a4d18
to
9a9ad63
Compare
This is a catch-all commit for many structural changes to the package. This covers unifying analysisPlots and analysisMetrics as well as laying the ground work for dispatching Metrics to a time series database. There are a few other quality of life changes that were made during the refactoring process such as the introduction of a finalize method.
natelust
force-pushed
the
tickets/DM-37918
branch
from
9a9ad63
to
d292404
Compare
| from lsst.analysis.tools.contexts import * | ||
| analyzeObjectTableSurveyCore: | ||
| class: lsst.analysis.tools.tasks.ObjectTableSurveyAnalysisTask | ||
| config: | ||
| connections.outputName: objectTableSurvey | ||
| plots.rhoStatisticsPlot: RhoStatisticsPlot | ||
| plots.rhoStatistics: RhoStatistics |
There was a problem hiding this comment.
Should this have changed to atools from plots?
There was a problem hiding this comment.
Yeah, missed one. I left an alias in place so it would not be broken now anyway, but it is best to change it
There was a problem hiding this comment.
Okay, just wanted to confirm. I'll change it as part of DM-38770.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a draft so people can view the changes easily, and comment on it. It is not intended to be taken as the final product (or even fully working)