Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38549: Fix Pandas 2 incompatibility. #77

Merged
merged 2 commits into from Apr 12, 2023
Merged

DM-38549: Fix Pandas 2 incompatibility. #77

merged 2 commits into from Apr 12, 2023

Conversation

ktlim
Copy link
Contributor

@ktlim ktlim commented Apr 12, 2023

No description provided.

@ktlim
Copy link
Contributor Author

ktlim commented Apr 12, 2023

Since main is failing mypy, I guess this branch is allowed to fail too?

@timj
Copy link
Member

timj commented Apr 12, 2023

@natelust has been telling me not to merge anything until his refactor turns up (See #72 )

@natelust
Copy link
Contributor

@timj I think I might not be communicating well. I am happy for people to do whatever they need to do if they want to, I just personally feel bad if I think someone is needed to do something that should have been my responsibility. That is why I offered to let you or whoever dump the work back on me. I am happy if people do want to do the extra work, and I will always work around it.

@timj
Copy link
Member

timj commented Apr 12, 2023

Or we can temporarily disable the mypy requirement for PRs to merge.

@natelust
Copy link
Contributor

I'm fixing all the mypy suff now and will push a commit

@natelust
Copy link
Contributor

I'm grabbing coffee but I should be done with the commit withing 10 minutes

@natelust
Copy link
Contributor

And I put it on the wrong branch...

@ktlim
Copy link
Contributor Author

ktlim commented Apr 12, 2023

No problem, just let me know when to rebase.

@natelust
Copy link
Contributor

Ok, I pushed a commit lets see if github mypy and my local mypy agree

@ktlim ktlim merged commit 4a5959e into main Apr 12, 2023
7 checks passed
@ktlim ktlim deleted the tickets/DM-38549 branch April 12, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants