DM-37703: Use InMemoryDatasetHandle and drop DatasetRef from test #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
commented
Apr 18, 2023
| dataframe : `pandas.DataFrame` | ||
| dataframe, cut to the specified columns. | ||
| """ | ||
| if "columns" in parameters: |
There was a problem hiding this comment.
It doesn't look like this parameter is ever used because it looks like this code has been copied from an implementation that had been used for pandas DataFrame objects -- the tests pass and SimpleCatalog is not configured to understand a columns parameter.
erykoff
approved these changes
Apr 18, 2023
It's not needed any where. The test only needs to store the region for later.
It was too old and isort would not work.
timj
commented
Apr 19, 2023
| @@ -65,10 +39,6 @@ class MockDataId: | |||
| def __init__(self, region): | |||
| self.region = region | |||
|
|
|||
| datasetDimensions = DimensionUniverse().extract(["htm7"]) | |||
| datasetType = DatasetType("gaia_dr2_20200414", datasetDimensions, StorageClass("SimpleCatalog")) | |||
| self.ref = DatasetRef(datasetType, {"htm7": "mockRefCat"}) | |||
There was a problem hiding this comment.
Turns out this ref wasn't needed at all so I simply deleted it.
timj
changed the title
timj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.