Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39005: Restructure analysis tools docs landing page. #87

Merged
merged 1 commit into from May 9, 2023

Conversation

leeskelvin
Copy link
Contributor

No description provided.

@leeskelvin leeskelvin force-pushed the tickets/DM-39005 branch 5 times, most recently from 2fc3a4a to f320cbf Compare May 5, 2023 16:27
Copy link
Contributor

@cmsaunders cmsaunders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. My biggest comment is to change the reference to AnalysisPlot and AnalysisMetric.

A couple of other things:

  • Why do some of the plot types still not have hyperlinks?
  • Were the docs for nansigmaMad and sigmaMad supposed to disappear?

You can find Jira issues for this module under the `analysis_tools <https://jira.lsstcorp.org/issues/?jql=project%20%3D%20DM%20AND%20component%20%3D%20analysis_tools>`_ component.

.. If there are topics related to developing this module (rather than using it), link to this from a toctree placed here.
If you have any questions regarding ``analysis_tools`` it is recommended that you post your question on `The Community Forum <https://community.lsst.org/>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wanted to check that this was agreed on. Is someone assigned to look out for questions on Community, or do we expect that someone outside DRP is going to forward questions to us?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that the official line is to always redirect questions from the community onto Community. Slack is convenient, but also seen as a transient resource (i.e., not good for long-term information storage). Happy to punt on this one however if you would like to bring it up for a broader discussion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update from Yusra via Slack:

We can only direct staff to Slack. Your commissioning in-kinds are considered staff, so if you’re talking about comms to them in particular, you can direct them to Slack. But if this is going on the pipelines.lsst.io, you need to only direct them to community. That’s our only official user support.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the Slack component, and leaving Community here in this section accordingly.

There are two types of primary tools within this package; `AnalysisMetrics
and `AnalysisPlots`, both of which are specialized subclasses of `AnalysisTool`.
There are two primary types of tools within this package: `AnalysisMetrics` and
`AnalysisPlots`, both of which are specialized subclasses of `AnalysisTool`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is AnalysisTool now, so this should be rewritten.

Copy link
Contributor Author

@leeskelvin leeskelvin May 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to (and merged with the next paragraph):

The primary tool in this package is the AnalysisTool class.
An AnalysisTool class has three stages: prep, process, and produce.
Creating a new AnalysisTool involves choosing (through
configuration) an AnalysisAction to run for each of those stages.

configuration) what `AnalysisAction` will run for each of those stages.
An `AnalysisTool` object has three stages: prep, process, and produce.
Creating a new `AnalysisTool` involves choosing (through
configuration) an `AnalysisAction` to run for each of those stages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you can use multiple actions for each stage, how about "which AnalysisActions to run..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified the final sentence to read:

Creating a new AnalysisTool involves choosing (through configuration) one or
more AnalysisAction classes to run for each of those stages.

@leeskelvin leeskelvin force-pushed the tickets/DM-39005 branch 2 times, most recently from b7b6b06 to ccaf6a9 Compare May 8, 2023 21:14
@leeskelvin
Copy link
Contributor Author

leeskelvin commented May 9, 2023

Replies:

Why do some of the plot types still not have hyperlinks?

I think this was a transient thing in the testing docs I built. I played around a few times, regenerating them, and they seem to work fine now. I'll keep an eye on this in the built docs to make sure all is well.

Were the docs for nansigmaMad and sigmaMad supposed to disappear?

No, they were not, thank you for catching that. They've been added back in by adding the :include-all-objects: option under the primary automodapi directive 👍

@leeskelvin leeskelvin merged commit e88789f into main May 9, 2023
7 checks passed
@leeskelvin leeskelvin deleted the tickets/DM-39005 branch May 9, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants