DM-39089: Handle failure modes in Sasquatch Dispatch #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle failure modes in Sasquatch Dispatching where the reference_package is a None value, and when there is no data in a bundle to upload.
It was decided that there will not be a different lsst.debug namespace, but that development work would happen on a difference Sasquatch instance. Accordingly change the default namespace such that it is the same across all instances.
afausti
approved these changes
May 8, 2023
| @@ -354,7 +354,8 @@ def _handleReferencePackage(self, meta: MutableMapping, bundle: MetricMeasuremen | |||
| except ValueError: | |||
| # Could not extract package timestamp leaving empty | |||
| pass | |||
| meta["reference_package"] = ref_package | |||
| # explicit handle if None was set in the bundle for the package | |||
| meta["reference_package"] = ref_package or "" | |||
There was a problem hiding this comment.
Looks good, fields must be present in the payload even if the value is missing. An empty string is a good default value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle failure modes in Sasquatch Dispatching where the reference_package is a None value, and when there is no data in a bundle to upload.