DM-37174: Close opened matplotlib figures in analysis_tools #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeskelvin
force-pushed
the
tickets/DM-37174
branch
from
b4e8c6b
to
998f091
Compare
leeskelvin
force-pushed
the
tickets/DM-37174
branch
3 times, most recently
from
fe51783
to
d1354c2
Compare
leeskelvin
force-pushed
the
tickets/DM-37174
branch
from
d1354c2
to
860ac70
Compare
| # TODO: This rcParams modification is a temporary solution, hiding | ||
| # a matplotlib warning indicating too many figures have been opened. | ||
| # When DM-39114 is implemented, this should be removed. | ||
| plt.rcParams.update({"figure.max_open_warning": 0}) |
There was a problem hiding this comment.
@leeskelvin do you happen to remember your rationale behind including this line inside runQuantum instead of at the module level or class level?
There was a problem hiding this comment.
It seemed like the best place for such a catch-all config at the time, however, I'm not beholden to it. Is it causing issues elsewhere?
There was a problem hiding this comment.
No issues yet, but this method is overridden in a few tasks and they miss this. I think because they are an exception instead of the norm, it doesn't lead to too many open figures but I figured it might be best places elsewhere. I'm working on a ticket that generalizes this method further and can move it on that ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.