Skip to content

Commit

Permalink
Finished second round of reviewer comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
morriscb committed Aug 1, 2017
1 parent 9b8c8ff commit 01dbeb0
Showing 1 changed file with 15 additions and 5 deletions.
20 changes: 15 additions & 5 deletions tests/test_dia_object.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,14 @@ def test_init(self):
dia_obj = DIAObject(single_source, None)
dia_obj_dup = DIAObject(single_source, dia_obj.dia_object_record)

self._compare_dia_object_values(dia_obj, 0, 0.0)
self._compare_dia_object_values(dia_obj_dup, dia_obj.id, 0.0)
compare_values = {
"coord_ra": 0.0,
"coord_dec": 0.0
}

self._compare_dia_object_values(dia_obj, 0, compare_values)
self._compare_dia_object_values(dia_obj_dup, dia_obj.id,
compare_values)

def _compare_dia_object_values(self, dia_object, expected_id,
expected_dict):
Expand All @@ -81,13 +87,17 @@ def _compare_dia_object_values(self, dia_object, expected_id,
expected_id : int
Expected id of the DIAObject
expected_dict : dict
Dictionary of field name and expected value
Dictionary of field name and expected value
"""

self.assertEqual(dia_object.get('id'), expected_id)
for key in expected_dict.keys():
self.assertAlmostEqual(dia_object.get(key),
expected_dict[key])
if isinstance(dia_object.get(key), afwGeom.Angle):
self.assertAlmostEqual(dia_object.get(key).asDegrees(),
expected_dict[key])
else:
self.assertAlmostEqual(dia_object.get(key),
expected_dict[key])

def test_update(self):
""" If we instantiate the class with a set of DIASources we test to
Expand Down

0 comments on commit 01dbeb0

Please sign in to comment.