DM-26592: Create “afterburner” to analyse the results of AP processing with fakes included #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgabor
approved these changes
Nov 25, 2020
| @@ -95,6 +95,19 @@ class DiaPipelineConnections(pipeBase.PipelineTaskConnections, | |||
| storageClass="Config", | |||
| dimensions=("instrument", "visit", "detector"), | |||
| ) | |||
| associatedDiaSources = connTypes.Output( | |||
| doc="Optional output storing the DiaSource catalog after matching and " | |||
| "SDMification.", | |||
There was a problem hiding this comment.
Please avoid the SDMification jargon. I could not find any usable definition anywhere in the docs, appears occasionally in jira tickets only. Point to a relevant DMTN if there is any or the typical task (MapDiaSourceTask ?) that produces this data model.
Modify output name. Fix output in struct.
morriscb
force-pushed
the
tickets/DM-26592
branch
from
3d23331
to
548396e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.