Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-27170: Deprecate and phase out afw::image::Filter #102

Merged
merged 2 commits into from Jan 29, 2021

Conversation

parejkoj
Copy link
Contributor

@parejkoj parejkoj commented Jan 2, 2021

No description provided.

Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit worried about the removal of filterId (which should have been its own commit, IMO), so I'd like that cleared up before I approve.

data/apdb-ap-pipe-schema-extra.yaml Show resolved Hide resolved
python/lsst/ap/association/diaForcedSource.py Show resolved Hide resolved
tests/test_diaForcedSource.py Show resolved Hide resolved
This includes a change to the APDB schema, but we do not support using
one version of the stack with an APDB produced by a different version.
* bandLabel is the closest replacement for `getCanonicalName()[0]`,
though it is not guaranteed to be a single character.
* defineFilter is no longer needed.
@parejkoj parejkoj merged commit 9dbe4d1 into master Jan 29, 2021
@parejkoj parejkoj deleted the tickets/DM-27170 branch January 29, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants