DM-23032: CreateSDM functor for bitpacking mutiple flag columns #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debug bitpacking and unittests.
isullivan
approved these changes
Mar 30, 2021
Comment on lines
+115
to
+118
| for table in table_list: | ||
| if table['tableName'] == 'DiaSource': | ||
| self.bit_pack_columns = table['columns'] | ||
| break |
There was a problem hiding this comment.
Do you need the for loop here, since you're just iterating through until you find the table with the correct name?
There was a problem hiding this comment.
Considering the yaml file could have flags for different tables (DiaObject, SSObject) and no enforced ordering, it makes sense to just go through the named tables and load the one we want.
| Parameters | ||
| ---------- | ||
| input_flag_values : array-like of type uint | ||
| Input integer flags to unpack. |
There was a problem hiding this comment.
"Input" does not need to be capitalized.
| output_flags = np.zeros(len(input_flag_values), dtype=bit_names_types) | ||
|
|
||
| for bit_idx, (bit_name, dtypes) in enumerate(bit_names_types): | ||
| masked_bits = np.bitwise_and(input_flag_values, 2 ** bit_idx) |
There was a problem hiding this comment.
Remove spaces in 2 ** bit_idx
| self.exposure, self.inputCatalog = dataset.realize(10.0, schema, randomSeed=1234) | ||
| # Make up expected task inputs. |
There was a problem hiding this comment.
Could you please re-word this comment? I find the meaning ambiguous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.