DM-13477: Move association math from DIAObjectCollection into AssociationTask #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
approved these changes
Feb 27, 2018
|
|
||
| Returns | ||
| ------- | ||
| lsst.pipe.base.Struc |
There was a problem hiding this comment.
Please document what fields the struct contains
Also Struc -> Struct
tests/test_association_task.py
Outdated
| dia_collection.get_dia_object(obj_id).n_dia_sources, 1) | ||
| else: | ||
| self.assertEqual( | ||
| dia_collection.get_dia_object(obj_id).n_dia_sources, 2) |
There was a problem hiding this comment.
What you have works, but I feel the following is a bit easier to read. Your choice.
# We created a new DIAObject in the collection hence the last
# DIAObject in this collection is new and contains only one
# DIASource. All others contain two.
self.assertEqual(
dia_collection.get_dia_object(updated_ids[-1]).n_dia_sources, 1)
for obj_id in updated_ids[0:-1]:
self.assertEqual(
dia_collection.get_dia_object(obj_id).n_dia_sources, 2)
Begining the redesign of DIAObjects into mor light weight afw.Table objects. Fix bugs in unittests. Changed afwImage.makeWcs to new SkyWcs. Removed cKDTree from association.py Changed test values in test_association_task.py
Added description of struct output to associate_sources method. Restructed score_and_match test case for clairity.
morriscb
force-pushed
the
tickets/DM-13477
branch
from
6a4133c
to
63015b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the score and match methods from DIAObjectCollection into AssociationTask. Also fixed problems associated with SkyWcs.