DM-30030: Make calibration source selection consistent between gen2 and gen3 middleware - part deux #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
May 18, 2021
tests/test_loadDiaCatalogs.py
Outdated
| @@ -370,6 +370,7 @@ def testGetPixelRanges(self): | |||
| the WCS. | |||
| """ | |||
| diaConfig = LoadDiaCatalogsConfig() | |||
| diaConfig.pixelMargin = 300 | |||
There was a problem hiding this comment.
I presume this is necessary because the test has some sensitive thresholds you don't want to tinker with? If so, please add a comment to that effect, so nobody thinks it's more important than that.
This parameter should be kept in sync with the padding settings elsewhere in the codebase. In particular, with the pixelMargin value set for the LoadReferenceObjectsConfig, which now defaults to 250.
The tests here were set using the old default of 300 for pixelMargin (now updated to 250). Rather than change the tests, override the config in the test to the value it was conditioned on.
laurenam
force-pushed
the
tickets/DM-30030
branch
from
e2c5baf
to
bee3d26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.