DM-30798: Update to new adjustQuantum signature. #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
approved these changes
Jun 17, 2021
Comment on lines
115
to
126
| inputs : `dict` | ||
| Dictionary whose keys are an input (regular or prerequisite) | ||
| connection name and whose values are a tuple of the connection | ||
| instance and a collection of associated `DatasetRef` objects. | ||
| The exact type of the nested collections is unspecified; it can be | ||
| assumed to be multi-pass iterable and support `len` and ``in``, but | ||
| it should not be mutated in place. In contrast, the outer | ||
| dictionaries are guaranteed to be temporary copies that are true | ||
| `dict` instances, and hence may be modified and even returned; this | ||
| is especially useful for delegating to `super` (see notes below). | ||
| outputs : `Mapping` | ||
| Mapping of output datasets, with the same structure as ``inputs``. |
There was a problem hiding this comment.
Did you intend for inputs to be dict but outputs (and everything else) to be Mapping?
There was a problem hiding this comment.
Oh, good catch. I did not, and that's a mistake down in pipe_base, too (should be dict throughout). I'll fix it here on this branch, but fix up pipe_base on a different ticket in that package that I already have underway.
This is a belated fix for an API change on DM-30649.
TallJimbo
force-pushed
the
tickets/DM-30798
branch
from
a6809d9
to
6ee6178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a belated fix for an API change on DM-30649.