DM-30926: Add SkySources to ImageDifferenceTask #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debug skySource code. Move around diaSource mask on sky_source flag.
morriscb
force-pushed
the
tickets/DM-30926
branch
from
d384610
to
2c894fc
Compare
kgabor
approved these changes
Jul 8, 2021
| @@ -85,6 +85,11 @@ class TransformDiaSourceCatalogConfig(pipeBase.PipelineTaskConfig, | |||
| "data", | |||
| "DiaSource.yaml") | |||
| ) | |||
| doRemoveSkySources = pexConfig.Field( | |||
| dtype=bool, | |||
There was a problem hiding this comment.
Please state default explicitly. Shouldn't it be the same as doSkySources in ImageDifferenceTask? Especially because this is enforced in ApPipe.yaml.
| @@ -223,7 +233,7 @@ def computeBBoxSizes(self, inputCatalog): | |||
| footprintBBox.minY - recY])))) | |||
| if bboxSize > maxSize: | |||
| bboxSize = maxSize | |||
| outputBBoxSizes[idx] = bboxSize | |||
| outputBBoxSizes.append(bboxSize) | |||
There was a problem hiding this comment.
outputBBoxSizes is now a list. Either update signature in docstring or convert to ndarray before return.
| @@ -205,8 +212,11 @@ def computeBBoxSizes(self, inputCatalog): | |||
| outputBBoxSizes : `numpy.ndarray`, (N,) | |||
| Array of bbox sizes. | |||
| """ | |||
| outputBBoxSizes = np.empty(len(inputCatalog), dtype=int) | |||
| outputBBoxSizes = [] | |||
| for idx, record in enumerate(inputCatalog): | |||
There was a problem hiding this comment.
idx is not used any more. Please remove.
Make clear default in config. Update doc. Remove unused variables. Fix typo
morriscb
force-pushed
the
tickets/DM-30926
branch
from
12131a5
to
d03ed09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.