DM-11162: Replace all use of Coord and subclasses with SpherePoint #12
Conversation
r-owen
force-pushed
the
tickets/DM-11162
branch
from
238d9b8
to
4fc6a3b
Compare
| .sconf_temp | ||
| config.log |
There was a problem hiding this comment.
Is there a reason to change where config.log appears in the file?
There was a problem hiding this comment.
I prefer having the .scons* files together
| @@ -136,7 +136,7 @@ def source_record_to_value_list(self, source_record): | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| source_record : afw.table.SourceRecord | |||
| source_record : lsst.afw.table.SourceRecord | |||
There was a problem hiding this comment.
Not related to the Coord -> SpherePoint conversion.
There was a problem hiding this comment.
True. Are you requesting that it be on a separate commit?
There was a problem hiding this comment.
I'm fine with it, but do we have a policy on this? I've been asked by other reviewers to do cleanups in separate commits, but I don't know if this is standard practice.
There was a problem hiding this comment.
I'll just drop that change. I have a version of this file whose docs are cleaned up, but I don't want to mess up the merge of DM-13478 so I'll just hold on to it privately for now.
| @@ -90,13 +89,11 @@ def edit_and_offset_source_record(src, src_id, ra_degrees, dec_degrees, | |||
| scatter_arcsec : float | |||
| Arcsecond scatter to add to the position of the source record coord. | |||
| """ | |||
| coord = Coord(afwGeom.Angle(ra_degrees, units=afwGeom.degrees), | |||
| afwGeom.Angle(dec_degrees, units=afwGeom.degrees)) | |||
| coord = lsst.afw.geom.SpherePoint(ra_degrees, dec_degrees, afwGeom.degrees) | |||
There was a problem hiding this comment.
This is a lovely example of how SpherePoint makes our lives better! 💯
r-owen
force-pushed
the
tickets/DM-11162
branch
from
4fc6a3b
to
4768d6a
Compare
No description provided.