DM-31033: Move DiaCalculation from a subtask of AssociationTask to a subtask of DiaPipe. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debug naming.
Remove DiaSource duplicate test. Fix DiaObject dup test. Add function to test for duplicates. Add function for DataFrame index checking. This is to allow for the usage of Mocks in unittesting. Fix typo.
kherner
reviewed
Jul 21, 2021
| @@ -89,10 +59,6 @@ class AssociationTask(pipeBase.Task): | |||
| ConfigClass = AssociationConfig | |||
| _DefaultName = "association" | |||
|
|
|||
| def __init__(self, **kwargs): | |||
| pipeBase.Task.__init__(self, **kwargs) | |||
| self.makeSubtask("diaCalculation") | |||
There was a problem hiding this comment.
Deleting the entire init function won't break anything else, will it? Certainly deleting the makeSubtask call makes sense, but you're killing the entire init function.
There was a problem hiding this comment.
The first line is calling the parent class init (written before super() was common) so if you are removing the second line the first line is not doing anything on its own.
kherner
approved these changes
Jul 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.