Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-29346: Compute PSFlux chi squared metric #121

Merged
merged 1 commit into from Jul 26, 2021
Merged

DM-29346: Compute PSFlux chi squared metric #121

merged 1 commit into from Jul 26, 2021

Conversation

parejkoj
Copy link
Contributor

@parejkoj parejkoj commented Jul 23, 2021 •
edited

Have to skip these columns until we update apdb on DM-31193.

@parejkoj parejkoj requested a review from kfindeisen July 23, 2021 20:39
kfindeisen
kfindeisen approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, though I don't really understand the distinction between base_* and slot_*.

@parejkoj
Copy link
Contributor Author

The base_ vs. slot_ duplications in dropColumns can probably be fixed by using schema.disconnectAliases() before doing the pandas conversion to remove the slot aliases. That will require further work, however, since the slot_ fields are used in the existing code.

@parejkoj parejkoj merged commit 565e9b2 into master Jul 26, 2021
@parejkoj parejkoj deleted the tickets/DM-29346 branch July 26, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfindeisen kfindeisen kfindeisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@parejkoj @kfindeisen