DM-32682: Mock out metadata setting in test #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktlim
approved these changes
Dec 3, 2021
With the task mocked out the metadata values calculated by the task are no longer real values but are themselves MagicMock objects. MagicMock objects can't be stored in a TaskMetadata so instead the run methods for the associator subtasks are explicitly mocked to return usable data for the metadata. This works with PropertySet since that seems to accept the mock value and silently ignores it.
timj
force-pushed
the
tickets/DM-32682
branch
from
4f756f7
to
e1e0571
Compare
|
@ktlim I took another look and realized that if I mocked out the |
ktlim
approved these changes
Dec 4, 2021
| with patch.multiple( | ||
| task, **{task: DEFAULT for task in subtasksToMock + ["apdb"]} | ||
| ): | ||
| with patch('lsst.ap.association.diaPipe.pd.concat', | ||
| new=concatMock): | ||
| with patch('lsst.ap.association.diaPipe.pd.concat', new=concatMock), \ |
There was a problem hiding this comment.
I believe you can parenthesize this whole thing, eliminating the need for backslashes. And can you add in the patch.multiple() as well?
There was a problem hiding this comment.
Oh, sorry, the parenthesized list may be Python 3.9.
There was a problem hiding this comment.
I didn't merge it with the patch.multiple because I didn't want to change the indent level of the code I wasn't touching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the task mocked out the metadata values calculated
by the task are no longer real values but are themselves
MagicMock objects. MagicMock objects can't be stored in
a TaskMetadata so we need to mock out the API that
sets the metadata.
This works with PropertySet since that seems to accept
the value and silently ignores it.