DM-34480: Updates for APDB schema definition #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebellm
approved these changes
May 7, 2022
APDB schema definition moved to felis, it is now defined as a single file in `sdm_schemas/yml/apdb.yaml`. Configuration parameter `extra_schema_file` was deprecated, I removed it from this package, and dropped corresponding YAML file from data/ folder. Few small changes were needed in unit tests to better match new schema.
andy-slac
force-pushed
the
tickets/DM-34480
branch
from
aa40f0b
to
b464df2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APDB schema definition moved to felis, it is now defined as a single
file in
sdm_schemas/yml/apdb.yaml. Configuration parameterextra_schema_filewas deprecated, I removed it from this package, anddropped corresponding YAML file from data/ folder. Few small changes
were needed in unit tests to better match new schema.