Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-31934: Replace HH:MM:SS conversion code with astropy equivalents. #149

Merged
merged 1 commit into from May 20, 2022
Merged

DM-31934: Replace HH:MM:SS conversion code with astropy equivalents. #149

merged 1 commit into from May 20, 2022

Conversation

ebellm
Copy link
Contributor

@ebellm ebellm commented May 18, 2022

No description provided.

kfindeisen
kfindeisen approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, style comments only. Please do merge the two commits, though, so that the package builds after every commit.

python/lsst/ap/association/skyBotEphemerisQuery.py Outdated Show resolved Hide resolved
@ebellm ebellm merged commit 11d8bb0 into main May 20, 2022
@ebellm ebellm deleted the tickets/DM-31934 branch May 20, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj left review comments

@kfindeisen kfindeisen kfindeisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ebellm @timj @kfindeisen