DM-43389: Add option to disable loading diaForcedSource history #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
reviewed
Mar 20, 2024
| Raises | ||
| ------ | ||
| RuntimeError | ||
| If the Database query failed to load DiaObjects |
There was a problem hiding this comment.
Suggested change
| If the Database query failed to load DiaObjects | |
| Raised if the Database query failed to load DiaObjects. |
| @@ -79,6 +82,11 @@ def run(self, exposure, apdb): | |||
| exposure padded by ``pixelMargin``. DataFrame is indexed by | |||
| ``diaObjectId``, ``band``, ``diaSourceId`` columns. | |||
| (`pandas.DataFrame`) | |||
|
|
|||
There was a problem hiding this comment.
The Returns block above this is missing diaForcedSources.
There was a problem hiding this comment.
Ha. That's been missing for a while... I'll add it.
Comment on lines
+250
to
+255
| doc="Load forced DiaSource history from the APDB?" | ||
| "This should only be turned off for debugging purposes.", | ||
| ) |
There was a problem hiding this comment.
I feel like this docstring should say something about how this was added to let us turn off forced sources for performance reasons? Maybe something like this?
Suggested change
| doc="Load forced DiaSource history from the APDB?" | |
| "This should only be turned off for debugging purposes.", | |
| ) | |
| doc="Load forced DiaSource history from the APDB?" | |
| " This should only be turned off for debugging purposes." | |
| " Added to allow disabling forced sources for performance reasons during the ops rehearsal.", | |
| ) |
Comment on lines
+70
to
+71
| Load forced DiaSource history from the APDB? | ||
| This should only be turned off for debugging purposes. |
There was a problem hiding this comment.
Same note as above with the config docstring.
isullivan
force-pushed
the
tickets/DM-43389
branch
from
69c730a
to
408ba98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a debugging-only option. I elected to pass
doLoadForcedSourcesin toLoadDiaCatalogsTask.run()rather than set it as a config of the subtask, thinking that it would be easier to remove in the future this way. I would welcome alternate suggestions!