DM-40507: Cleanup DipoleFitTask #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Mar 23, 2024
|
I believe you saw this already, but note that two tests currently fail: |
parejkoj
force-pushed
the
tickets/DM-40507
branch
2 times, most recently
from
029b4b8
to
483ce6c
Compare
This is by far the better algorithm, and produces a different set of flags.
We should never assume a flag maps to a specific bit. Fix incorrect test docstring.
parejkoj
force-pushed
the
tickets/DM-40507
branch
from
483ce6c
to
dee524b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.