tickets/DM-11283: Spec out DIAObjectCollection API #2
Conversation
| ---------- | ||
| dia_objects : a list of DIAObjects | ||
| List of DIAObjects that represent the collection of variable | ||
| objects for this visit. Each DIAOjbect will be individually |
| pass | ||
|
|
||
| def match(self, dia_source_catalog, scores): | ||
| """ Append DIAsources to DIAObjectds given a score and create new |
| Parameters | ||
| ---------- | ||
| dia_source_catalog : an lsst.afw.SourceCatalog | ||
| A contiguous catalo of dia_sources for which the set of scores |
| Parameters | ||
| ---------- | ||
| dia_source_catalog : an lsst.afw.SourceCatalog | ||
| A contiguous catalo of dia_sources to "score" based on distance |
| Attributes | ||
| ---------- | ||
| dia_objects : a list of DIAObjects | ||
| List of DIAObjects representing this collection the current (e.g.) |
There was a problem hiding this comment.
Rather than storing the DIAObjects as a list, I think it may make sense to store them in a dictionary for fast access by id. I am open to counterarguments, though.
There was a problem hiding this comment.
That makes sense. One hesitation I have for this is that the scoring and matching step is most easily done on the relative position in a list rather than a id in a dictionary. What if I add a dictionary internal to the class that is keyed on the id and returns the index in the list? I think I would hide this from user through some overwriting of built in functions or create a accessor method that uses the id as the input and returns the DIAObject of interest through the dictionary of id to list position. Let me know if this sounds reasonable and I'll implement it.
There was a problem hiding this comment.
Just made a first past commit on a the dictionary I described. Let me know if this works for you.
| bool | ||
| """ | ||
|
|
||
| return self._is_valid_tree |
There was a problem hiding this comment.
I don't see any methods dealing with persistence to/from a data store in here. Should those be internal to the class or external? My guess is external (mocking up something like Butler.put()), etc., but can you tell me your thoughts here?
There was a problem hiding this comment.
Sure. I think this is something that gets taken care of by the future AssociationTask. On instantiation this would query where ever the DIAObjects are stored and then create the DIAObjectCollection for the association step. AssociationTask would then take care of writing the data as well.
morriscb
force-pushed
the
tickets/DM-11283
branch
from
a165f68
to
a9021a6
Compare
Added id_to_index dictionary and method Finished review comments.
morriscb
force-pushed
the
tickets/DM-11283
branch
from
889842e
to
c2bb45d
Compare
No description provided.