DM-14885: Use either nanoseconds or MJD in PPDB CcdVisit table #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
reviewed
Jun 26, 2018
| @@ -163,7 +164,7 @@ def get_ccd_visit_info_from_exposure(exposure): | |||
| 'ra': sphPoint.getRa().asDegrees(), | |||
| 'decl': sphPoint.getDec().asDegrees(), | |||
| 'expTime': visit_info.getExposureTime(), | |||
| 'expMidptMJD': visit_info.getDate().nsecs() * 10 ** -9, | |||
| 'expMidptMJD': date.get(date.MJD), | |||
There was a problem hiding this comment.
Perhaps have it as date.get(system=DateTime.MJD) to be more explicit? (This is what Eli says he uses on Slack in the dm channel)
Please also update the values list comment above; the field name is expMidptMJD but it is described above as dateTimeMJD in seconds. Otherwise 💯 and many thanks
mrawls
approved these changes
Jun 26, 2018
Change type description and DateTime.get call. Fix typo in MJD call.
morriscb
force-pushed
the
tickets/DM-14885
branch
from
a73b662
to
4bd90b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.