DM-43414: Update unit tests for changes in APDB API #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
force-pushed
the
tickets/DM-43414
branch
3 times, most recently
from
1893fae
to
bbb7794
Compare
kfindeisen
approved these changes
Mar 29, 2024
|
|
||
| Apdb.makeSchema(self.apdbConfig) | ||
| self.apdb = ApdbSql(config=self.apdbConfig) | ||
| self.apdbConfig = ApdbSql.init_database(db_url="sqlite:///" + self.db_file) |
There was a problem hiding this comment.
Is init_database preferred to create_sql?
There was a problem hiding this comment.
create_sql and all stuff in lsst.dax.apdb.scripts is for CLI use (apbd-cli or any other CLI might need that). For regular Python code init_database is the main interface.
APDB initialization is now done via special class method `init_database`, test cases in this package are updated to use new API.
andy-slac
force-pushed
the
tickets/DM-43414
branch
from
bbb7794
to
3bd5aca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APDB initialization is now done via special class method
init_database, test cases in this package are updated to use new API.