Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-15794: Change fluxSigma to fluxErr in ap_association #25

Merged
merged 2 commits into from Sep 18, 2018
Merged

DM-15794: Change fluxSigma to fluxErr in ap_association #25

merged 2 commits into from Sep 18, 2018

Conversation

morriscb
Copy link
Contributor

No description provided.

kfindeisen
kfindeisen approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, though I'm a bit disturbed by the code duplication I see here. ap_pipe now runs to completion.

While testing the changes, I noticed that .coverage is not git-ignored. Would you mind adding it to the list?

@morriscb morriscb merged commit 183ffc6 into master Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfindeisen kfindeisen kfindeisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morriscb @kfindeisen