DM-15775: Migrate to dax_ppdb instead of l1dbproto #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
approved these changes
Sep 26, 2018
| @@ -146,7 +147,7 @@ def load_dia_objects(self, exposure): | |||
|
|
|||
| indexer_indices, on_boundry = self.indexer.getShardIds( | |||
| ctr_coord, max_radius) | |||
| # Index types must be cast to int to work with l1dbproto. | |||
| # Index types must be cast to int to work with dax.ppdb. | |||
There was a problem hiding this comment.
I think dax_ppdb would be more understandable.
l1dbproto package was replaced by dax_ppdb, need to rename imports and class names here, and update table file. All unit tests pass after the renaming.
andy-slac
force-pushed
the
tickets/DM-15775
branch
from
ba473a0
to
2ce1b03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
l1dbproto package was replaced by dax_ppdb, need to rename imports and
class names here, and update table file. All unit tests pass after the
renaming.