Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-11041: Implement simple DIAObject to DIASource matching algorithm and flesh out DIACollection #3

Merged
merged 5 commits into from
Sep 7, 2017
Merged

DM-11041: Implement simple DIAObject to DIASource matching algorithm and flesh out DIACollection #3

merged 5 commits into from
Sep 7, 2017

Commits on Aug 1, 2017

  1. Implimented first pass at match and score.

    @morriscb
    morriscb committed Aug 1, 2017
    Configuration menu
    Copy the full SHA
    97068d4 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2017

  1. Finished first unittest for dia_collection.py 

    dia_collection.py: Finished first pass implimentation
Added association.py

Fixed bugs in dia_collection and unittest.

Passes most of unittests. Need to edit score and match both within
test and class.
    @morriscb
    morriscb committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    5f3654b View commit details
    Browse the repository at this point in the history

  2. Simplified score and match methods.

    @morriscb
    morriscb committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    56c93d3 View commit details
    Browse the repository at this point in the history

  3. Changed unittest to reflect new simple association. 

    Finished unittest and matching implementation.
    @morriscb
    morriscb committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    e6102c7 View commit details
    Browse the repository at this point in the history

  4. Colmeted response to reviewer 

    Finalized tests for second reviewer pass

Completed responses for second reviewer pass.

Added auto-linting/flake8-ing to scons scrips.

Changed assertEqual in test_dia_collection.py

Also fixed linting in association.py

Fixed spelling error.

Fixed some linting errors in test_dia_collection.py
    @morriscb
    morriscb committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    3c72d54 View commit details
    Browse the repository at this point in the history