DM-15928: Propagate DIASource flags into PPDB #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edit formating of bit pack yaml file. Edit formating of bit pack to mimic ppdb schema formating.
Add unittest for bit-packing. Fix bugs in bit-packing tests. Change ValueError to KeyError
Debug integer bit unpacker.
Fix typo. Fix grammar in comment. Fix formating in afw doc.
ebellm
requested changes
Dec 17, 2018
| @@ -24,14 +24,20 @@ | |||
| """ | |||
|
|
|||
| __all__ = ["MapApDataConfig", "MapApDataTask", | |||
| "MapDiaSourceConfig", "MapDiaSourceTask"] | |||
| "MapDiaSourceConfig", "MapDiaSourceTask", | |||
| "UpackPpdbFlags"] | |||
There was a problem hiding this comment.
Can we call this UnpackPpdbFlags instead? (here and throughout)
There was a problem hiding this comment.
Opps, that was a typo. Fixed.
| def _create_bit_pack_mappings(self): | ||
| """Setup all flag bit packings. | ||
| """ | ||
| output_columns = [] |
There was a problem hiding this comment.
I think you can omit the temporary variable output_columns and just use self.bit_pack_columns directly
| """ | ||
|
|
||
| def __init__(self, flag_map_file, table_name): | ||
| output_columns = [] |
There was a problem hiding this comment.
Again, I think you can omit the temporary variable output_columns and just use self.bit_pack_columns directly
ebellm
approved these changes
Dec 18, 2018
Add more slot mappings. Fix typo in UnpackPpdbFlags name. Remove tempoarary output_columns variable.
morriscb
force-pushed
the
tickets/DM-15928
branch
from
1a064fa
to
692af66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.