DM-15795: Create DiaForcedSourceTask #40
Conversation
| 64 - expIdBits) | ||
| idFactoryDirect = afwTable.IdFactory.makeSource( | ||
| diffim.getInfo().getVisitInfo().getExposureId(), | ||
| 64 - expIdBits) |
There was a problem hiding this comment.
Could you use something like DM-17689 to avoid hard-coded numbers here?
tests/test_diaForcedSource.py
Outdated
| n_points : `int` | ||
| Number of DiaObject test points to create. | ||
| wcs : `lsst.afw.geom.SkyWcs` | ||
| Wcs to convert RA/Dec to x/y if provided. |
There was a problem hiding this comment.
What do you mean by "if provided" here? It doesn't look optional.
There was a problem hiding this comment.
Removed. I re-purposed a previous method.
tests/test_diaForcedSource.py
Outdated
| # Make images with one source in them and distinct values and | ||
| # variance for each image. | ||
| # Direct Image | ||
| ms = afwImage.MaskedImageF(lsst.geom.ExtentI(self.imageSize[0] + 1, |
There was a problem hiding this comment.
"ms" is not a very descriptive variable name. Is the "m" for masked image and the "s" for source? I'd prefer to see a slightly longer name, but I guess this is ok for a test.
There was a problem hiding this comment.
sorry, these were copy-pasted from a different unittest. I'll give them slightly more descriptive names.
tests/test_diaForcedSource.py
Outdated
| lsst.geom.PointI(1, 1), | ||
| lsst.geom.ExtentI(self.imageSize[0], | ||
| self.imageSize[1])) | ||
| self.mi = afwImage.MaskedImageF(ms, bbox, afwImage.LOCAL) |
There was a problem hiding this comment.
Does self.mi need to be saved as a class attribute? You're just overwriting the value you set it to a few lines back, which suggests you don't need it outside of setting up self.exposure and self.diffim.
tests/test_diaForcedSource.py
Outdated
|
|
||
| FWHM = 5 | ||
| psf = measAlg.DoubleGaussianPsf( | ||
| 15, 15, FWHM/(2*np.sqrt(2*np.log(2)))) |
There was a problem hiding this comment.
I think this could fit on one line.
Add DiaForcedSourceTask. Add bitpackin for direct and difference image flags. Simplify DiaForcedSourceTask. Simplify to DiaForcedSourceTask only.
morriscb
force-pushed
the
tickets/DM-15795
branch
2 times, most recently
from
4a39db4
to
03cc98f
Compare
Partially debuged unittest. Need to add footprints to measurement catalog. Partially debugged unittests. Add coord to centroid measurement plugin. Remove unnecessary code from inherited plugin class. Remove pdb statement. Fix linting Add test values. Create distict idFactories. Fix linting
Remove outdated docstring. Make better test variable names. Fix line spacing.
morriscb
force-pushed
the
tickets/DM-15795
branch
from
03cc98f
to
2bf19bc
Compare
No description provided.