DM-16536: Migrate all metrics from ap.verify.measurements #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebellm
requested changes
Mar 8, 2019
kfindeisen
force-pushed
the
tickets/DM-16536
branch
from
5a6fb62
to
98cfe29
Compare
kfindeisen
force-pushed
the
tickets/DM-16536
branch
2 times, most recently
from
5ceead1
to
5656c2b
Compare
ebellm
approved these changes
Mar 13, 2019
kfindeisen
force-pushed
the
tickets/DM-16536
branch
from
5656c2b
to
45862fd
Compare
kfindeisen
force-pushed
the
tickets/DM-16536
branch
from
45862fd
to
22ca914
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines
MetricTasksubclasses for theap_association.numNewDiaObjects,ap_association.numUnassociatedDiaObjects,ap_association.fracUpdatedDiaObjects, andap_association.totalUnassociatedDiaObjectsmetrics, which were previously implemented as functions inap_verify(see lsst/ap_verify#63). This change requires thatap_associationdepend onlsst.verify.Design note: most of the complexity of the task code comes from
MetricTaskinstances not being allowed to assume a particular granularity for their metric. This, in turn, is partly because of Gen 2 (i.e.,MetricsControllerTask) limitations, but largely because it's not yet known who will be responsible for metrics aggregation.