DM-19906: Convert diaForcedSourceTask to take pandas DataFrame as input #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement first pass unittest with pandas. Debug diaForcedSource Adjust unittest values to calibrated values. Debug diaForcedSource unittest. Change column name to slot Drop columns from output dataframe. Change x to y in dropped columns Fix linting Change name of database table to add columns to. Remove ra/dec from output diaForcedSource. Add midPointTai to ap_pipe schema. Move dropped columns to config. Debug unittests and linting. Add test on output column length.
Change measurement unittest to relative values. Remove places in unittest Change to relative tolerances
morriscb
force-pushed
the
tickets/DM-19906
branch
from
9df8aca
to
82f6fbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.