DM-20760: Drop DiaSources if RA/DEC is NaN and throw warning. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebellm
requested changes
Aug 1, 2019
| DataFrame of DiaSources trimmed of all entries with NaN values for | ||
| RA/DEC. | ||
| """ | ||
| nan_mask = np.logical_or(np.isnan(dia_sources.loc[:, "ra"]), |
There was a problem hiding this comment.
I would do this in a more native pandas way:
nan_mask = dia_sources["ra"].isnull() | dia_sources["decl"].isnull()
| "DiaSource %i has NaN value for RA/DEC, " | ||
| "dropping from association." % | ||
| dia_sources.loc[nan_idx, "diaSourceId"]) | ||
| dia_sources = dia_sources[np.logical_not(nan_mask)] |
There was a problem hiding this comment.
You might try a timing test of just this line and see if dia_sources[~nan_mask] is faster.
There was a problem hiding this comment.
I doubt there is much difference here so I'll change it to the simpler line.
| inplace=True) | ||
|
|
||
| dia_sources.loc[2, "ra"] = np.nan | ||
| dia_sources.loc[3, "decl"] = np.nan |
There was a problem hiding this comment.
this may be silly, but how about a check for both ra and decl as NaN?
|
Updated the ticket. Take a look. |
ebellm
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.